Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marcwo/dataform module #2001

Merged
merged 11 commits into from Jan 24, 2024
Merged

Marcwo/dataform module #2001

merged 11 commits into from Jan 24, 2024

Conversation

marcjwo
Copy link
Collaborator

@marcjwo marcjwo commented Jan 23, 2024

Module to create dataform repositories with IAM permissions.

  • simple repository with IAM permissions
  • repository connected with remote repository hosted in GH/GL with IAM permissions

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

lcaggio
lcaggio requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@lcaggio lcaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc for the PR! I did a first review, PTAL.

Can you also update README on parent folders?

modules/dataform-repository/main.tf Outdated Show resolved Hide resolved
modules/dataform-repository/README.md Show resolved Hide resolved
modules/dataform-repository/variables.tf Outdated Show resolved Hide resolved
modules/dataform-repository/variables.tf Outdated Show resolved Hide resolved
juliocc
juliocc requested changes Jan 23, 2024
View reviewed changes
modules/dataform-repository/main.tf Outdated Show resolved Hide resolved
modules/dataform-repository/variables.tf Outdated Show resolved Hide resolved
modules/dataform-repository/outputs.tf Outdated Show resolved Hide resolved
modules/dataform-repository/variables.tf Outdated Show resolved Hide resolved
modules/dataform-repository/variables.tf Outdated Show resolved Hide resolved
juliocc
juliocc approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes!

@juliocc juliocc enabled auto-merge (squash) January 24, 2024 15:37
@lcaggio
Copy link
Collaborator

lcaggio commented Jan 24, 2024

Thanks!!!

@juliocc juliocc merged commit 6b4dad0 into GoogleCloudPlatform:master Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn left review comments

@lcaggio lcaggio lcaggio approved these changes

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcjwo @lcaggio @juliocc @wiktorn