Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and additional support for ssl_mode for CloudSQL module #2002

Merged
merged 17 commits into from Jan 25, 2024

Conversation

spica29
Copy link
Contributor

@spica29 spica29 commented Jan 23, 2024

The CloudSQL module had some minor issues, which are covered in this PR. These are the following:

  1. "postgres_client_certificates" variable was renamed to "client_certificates" to make it more generic
  2. maintenance_config validation was failing when validating var.maintenance_config.maintenance_window if the var.maintenance_config is set to null
  3. support for ssl_mode with validation

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

Left a couple of comments below.

modules/cloudsql-instance/main.tf Show resolved Hide resolved
modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a couple small nits then it's good to go. :)

modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
modules/cloudsql-instance/main.tf Outdated Show resolved Hide resolved
@ludoo ludoo enabled auto-merge (squash) January 25, 2024 15:03
@ludoo ludoo merged commit 1a8400e into GoogleCloudPlatform:master Jan 25, 2024
9 checks passed
@ludoo
Copy link
Collaborator

ludoo commented Jan 25, 2024

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants