Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS query logging to FAST net stages #2033

Merged
merged 4 commits into from Jan 31, 2024
Merged

Add DNS query logging to FAST net stages #2033

merged 4 commits into from Jan 31, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jan 31, 2024

Fixes #2020

ludoo
ludoo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a variable to disable it? :)

@juliocc
Copy link
Collaborator Author

juliocc commented Jan 31, 2024

Can we have a variable to disable it? :)

Great idea. Let me do that

@juliocc juliocc requested a review from ludoo January 31, 2024 12:10
@juliocc juliocc merged commit 4c68c01 into master Jan 31, 2024
13 checks passed
@juliocc juliocc deleted the jccb/fix-2020-fast-dns-logging branch January 31, 2024 12:44
@ludoo
Copy link
Collaborator

ludoo commented Feb 3, 2024

Reopening this as I'm getting this error applying the changes in my existing net stage

image

@ludoo ludoo mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo Awaiting requested review from ludoo

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS Logging
2 participants
@juliocc @ludoo