Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e test for compute-mig module #2132

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

andybubu
Copy link
Contributor

@andybubu andybubu commented Mar 5, 2024


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@andybubu andybubu marked this pull request as ready for review March 5, 2024 20:16
@wiktorn
Copy link
Collaborator

wiktorn commented Mar 6, 2024

Destroy fails on:

google_compute_disk.test-disk: Still destroying... [id=projects/wfe-e2e-***-prj/zones/europe-west4-b/disks/test-data-1, 10s elapsed]
module.nginx-mig.google_compute_instance_group_manager.default[0]: Still destroying... [id=projects/wfe-e2e-
...
module.nginx-mig.google_compute_instance_group_manager.default[0]: Destruction complete after 2m4s
module.nginx-template.google_compute_instance_template.default[0]: Destroying... [id=projects/wfe-e2e-***-prj/global/instanceTemplates/nginx-template-20240306111725727800000001]
module.nginx-template.google_compute_instance_template.default[0]: Still destroying... [id=projects/wfe-e2e-***-prj/global...nx-template-20240306111725727800000001, 10s elapsed]
module.nginx-template.google_compute_instance_template.default[0]: Destruction complete after 11s
╷
│ Error: Error waiting for Detaching disk from wfe-e2e-***-prj/europe-west4-b/instance-1: Operation was canceled by user ''.

For Stateful MIGs - Instance Config test case.

This is probably due to the fact that in instance that is created we have this:

     - disk {
          - auto_delete           = true -> null
          - boot                  = false -> null
          - device_name           = "data-1" -> null
          - disk_size_gb          = 0 -> null
          - interface             = "SCSI" -> null
          - labels                = {} -> null
          - mode                  = "READ_WRITE" -> null
          - provisioned_iops      = 0 -> null
          - resource_manager_tags = {} -> null
          - resource_policies     = [] -> null
          - source                = "test-data-1" -> null
          - type                  = "PERSISTENT" -> null
        }

If the instance is auto_deleting the disk, then we can't delete explicitly.

@wiktorn wiktorn enabled auto-merge (squash) March 6, 2024 20:20
@wiktorn wiktorn merged commit 105a19b into GoogleCloudPlatform:master Mar 6, 2024
9 checks passed
@ludoo ludoo added the on:tools New or changed tool label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants