Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated diagram to better reflect code naming. #2133

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

bswenka
Copy link
Collaborator

@bswenka bswenka commented Mar 5, 2024


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bswenka. As far as I checked, the blueprint is not using the Identity Aware Proxy, so adding it to the diagram might be misleading. Otherwise looks good

@bswenka
Copy link
Collaborator Author

bswenka commented Mar 6, 2024

Good catch @wiktorn - I accidentally used an old version of the diagram, thank you. Fixed now.

@bswenka bswenka requested a review from wiktorn March 6, 2024 14:45
@wiktorn wiktorn enabled auto-merge (squash) March 6, 2024 19:13
@wiktorn wiktorn merged commit dcd5424 into master Mar 6, 2024
13 checks passed
@wiktorn wiktorn deleted the bswenka/psc-glb-and-armor-new-diagram branch March 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants