Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bfd and md5 auth support to google_compute_router_peer #2142

Merged
merged 5 commits into from
Mar 10, 2024
Merged

Adds bfd and md5 auth support to google_compute_router_peer #2142

merged 5 commits into from
Mar 10, 2024

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented Mar 10, 2024 •
edited

Adds bfd and md5 auth support to google_compute_router_peer

(Check if supported/required in modules first!)

  • modules/ncc-spoke-ra (BFD + MD5 Auth are unsupported)
  • modules/net-ipsec-over-interconnect (Done)
  • modules/net-vlan-attachment (Done)
  • modules/net-vpn-dynamic (MD5 Auth unsupported, BFD unclear)
  • modules/net-vpn-ha (Done)
  • blueprints/networking/ha-vpn-over-interconnect (IMHO overkill)
  • fast/stages/2-networking* (specifically for **/vpn-onprem.tf) (IMHO overkill)

@sruffilli
Copy link
Collaborator Author

Quoting BFD docs:
You can only enable BFD in BGP sessions that you configure for VLAN attachments in Dedicated Interconnect or Partner Interconnect. BFD is not supported in BGP sessions that are configured for HA VPN tunnels or for Router appliance, which is part of Network Connectivity Center.

@sruffilli
Copy link
Collaborator Author

Quoting HA-VPN over Cloud Interconnect docs:
Enabling Bidirectional Forwarding Detection (BFD) does not provide faster failure detection for HA VPN over Cloud Interconnect deployments.

@sruffilli
Copy link
Collaborator Author

sruffilli commented Mar 10, 2024 •
edited

MD5 auth docs:

Products that can use MD5 authentication include the following:

- [HA VPN](https://cloud.google.com/network-connectivity/docs/vpn/concepts/overview#ha-vpn)
- [Cloud Interconnect](https://cloud.google.com/network-connectivity/docs/interconnect/concepts/overview)

@sruffilli sruffilli marked this pull request as ready for review March 10, 2024 12:35
juliocc
juliocc approved these changes Mar 10, 2024
View reviewed changes
modules/net-ipsec-over-interconnect/main.tf Outdated Show resolved Hide resolved
modules/net-vpn-ha/main.tf Outdated Show resolved Hide resolved
modules/net-vpn-ha/main.tf Show resolved Hide resolved
@sruffilli sruffilli enabled auto-merge (squash) March 10, 2024 12:48
@sruffilli sruffilli merged commit eb0ed0c into master Mar 10, 2024
13 checks passed
@sruffilli sruffilli deleted the sruffilli/md5auth branch March 10, 2024 13:06
@sruffilli sruffilli mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@apichick apichick Awaiting requested review from apichick

@ludoo ludoo Awaiting requested review from ludoo

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sruffilli @juliocc