Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add e2e test for pubsub module #2163

Merged
merged 11 commits into from
Mar 20, 2024
Merged

feat: add e2e test for pubsub module #2163

merged 11 commits into from
Mar 20, 2024

Conversation

andybubu
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@andybubu andybubu marked this pull request as ready for review March 19, 2024 14:35
wiktorn
wiktorn reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy, looks good. One question to the code above.

modules/pubsub/README.md Outdated Show resolved Hide resolved
wiktorn
wiktorn reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments, sorry for missing them earlier.

tests/fixtures/gcs.tf Outdated Show resolved Hide resolved
tests/fixtures/bigquery.tf Outdated Show resolved Hide resolved
@wiktorn wiktorn merged commit 688c6cf into GoogleCloudPlatform:master Mar 20, 2024
9 checks passed
@ludoo ludoo added the on:tools New or changed tool label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andybubu @wiktorn @ludoo