Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmek option for cloud_run_v2 #2177

Merged

Conversation

SalehElnagarSecurrency
Copy link
Contributor

@SalehElnagarSecurrency SalehElnagarSecurrency commented Mar 26, 2024


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@SalehElnagarSecurrency SalehElnagarSecurrency changed the title add cmek option add cmek option for cloud_run_v2 Mar 26, 2024
@wiktorn
Copy link
Collaborator

wiktorn commented Mar 26, 2024

@SalehElnagarSecurrency you can use tools/tfdoc.py in the repo to regenerate the README.md

@SalehElnagarSecurrency
Copy link
Contributor Author

@SalehElnagarSecurrency you can use tools/tfdoc.py in the repo to regenerate the README.md

I haven't cloned the repo on my local )). but you're right. It's better to do it this way.

@juliocc
Copy link
Collaborator

juliocc commented Mar 26, 2024

@SalehElnagarSecurrency can fix the failing tests and linting issues?

Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
@wiktorn
Copy link
Collaborator

wiktorn commented Mar 26, 2024

@SalehElnagarSecurrency can fix the failing tests and linting issues?

@SalehElnagarSecurrency my guess is that the tests are failing, as the example you have added is missing: # tftest modules=n resources=nn line at the end. Substitute n and nn with actual numbers of modules / resources created.

Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
@juliocc juliocc enabled auto-merge (squash) March 26, 2024 22:34
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
auto-merge was automatically disabled March 26, 2024 22:51

Head branch was pushed to by a user without write access

Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
Signed-off-by: SalehElnagarSecurrency <saleh.elnagar@securrency.com>
@wiktorn wiktorn enabled auto-merge (squash) March 27, 2024 09:06
@wiktorn
Copy link
Collaborator

wiktorn commented Mar 27, 2024

Thanks a lot @SalehElnagarSecurrency !!

@wiktorn wiktorn merged commit 136d74d into GoogleCloudPlatform:master Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants