Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC module - PSA configurable service producer #2190

Conversation

spica29
Copy link
Contributor

@spica29 spica29 commented Apr 2, 2024


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc
Copy link
Collaborator

juliocc commented Apr 2, 2024

@spica29 the PR looks reasonable but I'm wondering what's the use case for this. I've never seen any other value besides "servicenetworking.googleapis.com".

@spica29
Copy link
Contributor Author

spica29 commented Apr 2, 2024

@spica29 the PR looks reasonable but I'm wondering what's the use case for this. I've never seen any other value besides "servicenetworking.googleapis.com".

Hi, we are trying to set up a PSA for NetApp and it uses another service: "netapp.servicenetworking.goog". Here is the documentation. I believe that we often just see GCP as a service producer, but we can also have third parties. There is not a lot of documentation about it though.

modules/net-vpc/variables.tf Outdated Show resolved Hide resolved
@ludoo ludoo enabled auto-merge (squash) April 2, 2024 18:02
@ludoo ludoo merged commit fb4a661 into GoogleCloudPlatform:master Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants