Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST GCVE stage #2191

Merged
merged 37 commits into from
Apr 3, 2024
Merged

FAST GCVE stage #2191

merged 37 commits into from
Apr 3, 2024

Conversation

eliamaldini
Copy link
Collaborator

@eliamaldini eliamaldini commented Apr 2, 2024

Hi Team,
this is the PR for the new FAST GCVE Stage, it includes:

  • a new blueprint
  • a new 3-gcve FAST stages
  • minor change to the gcve-private-clouds module
  • changes to the bootstrap stage
    • GCVE fast feature
    • custom role
  • changes to all the networking stages
    • to enable an API on the netspokes (on the basis of the feature flag)

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README comments

blueprints/gcve/pc-minimal/README.md Outdated Show resolved Hide resolved
blueprints/gcve/pc-minimal/README.md Outdated Show resolved Hide resolved
blueprints/gcve/pc-minimal/README.md Show resolved Hide resolved
blueprints/gcve/pc-minimal/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work

blueprints/gcve/pc-minimal/gcve-pc.tf Outdated Show resolved Hide resolved
fast/stages/2-networking-a-peering/net-dev.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice. I am just wondering if it would make sense to remove one level of indirection, and move the blueprint code to the FAST stage as the blueprint mainly just wraps the module and adds optional peerings.

blueprints/gcve/pc-minimal/variables.tf Show resolved Hide resolved
@eliamaldini
Copy link
Collaborator Author

Very very nice. I am just wondering if it would make sense to remove one level of indirection, and move the blueprint code to the FAST stage as the blueprint mainly just wraps the module and adds optional peerings.

This is the first version of the blueprint that as you said it just wraps the module....but in the next release we will add other features like monitoring agents etc...

@eliamaldini eliamaldini merged commit b80132a into master Apr 3, 2024
13 checks passed
@eliamaldini eliamaldini deleted the em-gcve-stage branch April 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants