Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quotas to project module #2210

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Add support for quotas to project module #2210

merged 9 commits into from
Apr 10, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Apr 10, 2024

Fixes #2193

@ludoo ludoo requested a review from juliocc April 10, 2024 11:23
modules/project/README.md Outdated Show resolved Hide resolved
@wiktorn
Copy link
Collaborator

wiktorn commented Apr 10, 2024

E2E test run to verify new testcase

@ludoo ludoo disabled auto-merge April 10, 2024 15:21
@ludoo
Copy link
Collaborator Author

ludoo commented Apr 10, 2024

Hold this while Wiktor deep dives on the quota project thingy. :)

@wiktorn
Copy link
Collaborator

wiktorn commented Apr 10, 2024

E2E tests succeeded (once cloudquotas.googleapis.com was enabled in IAC project by FAST stage) so I think we can remove the caveat regarding quota project.

@ludoo ludoo enabled auto-merge (squash) April 10, 2024 16:59
@ludoo ludoo disabled auto-merge April 10, 2024 16:59
@ludoo ludoo enabled auto-merge (squash) April 10, 2024 17:00
@ludoo ludoo merged commit 9cace52 into master Apr 10, 2024
13 checks passed
@ludoo ludoo deleted the ludo/project-quota branch April 10, 2024 17:03
@wiktorn wiktorn mentioned this pull request Apr 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new quota preference resource to project module and project factory
2 participants