Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GCS soft-delete retention period #2212

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Add support for GCS soft-delete retention period #2212

merged 5 commits into from
Apr 11, 2024

Conversation

sruffilli
Copy link
Collaborator

No description provided.

ludoo
ludoo requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable is too long. Can we do soft_delete_policy.retention_period if we assume more controls will be available later for it, or soft_delete_retention if not?

@sruffilli
Copy link
Collaborator Author

Variable is too long. Can we do soft_delete_policy.retention_period if we assume more controls will be available later for it, or soft_delete_retention if not?

Had the same gut feeling. I'll go with the latter.

@sruffilli sruffilli marked this pull request as ready for review April 11, 2024 07:24
@sruffilli sruffilli enabled auto-merge (squash) April 11, 2024 07:28
@sruffilli sruffilli merged commit 7833203 into master Apr 11, 2024
13 checks passed
@sruffilli sruffilli deleted the sruffilli/soft-delete branch April 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sruffilli @ludoo