Update FAST logging #2235
Merged
Update FAST logging #2235
+60
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
juliocc
commented
Apr 24, 2024
juliocc
commented
- Simplify syntax of default logging filters
- Add policy denied (i.e. IAM deny) logs to default audit logs sink
- Capture audit transparency logs using log name instead of metadata type
- Add new org-level sink for IAM data access logs
- Enable IAM data access logs in the IAC project
|
I'm always wary of turning on data access logs at the org level. I'm not sure this should be the default especially if we start targeting AI jumpstarts and mini-LZs... |
ludoo
approved these changes
Apr 25, 2024
Agreed, and it' not the default :) Data access logs are only enabled in the automation project and only for IAM. The sink is org-level in case the user wants to activate DAL somewhere else |
ludoo
reviewed
Apr 25, 2024
dibaskar-google
pushed a commit
to dibaskar-google/cloud-foundation-fabric
that referenced
this pull request
May 14, 2024
* Update FAST logging * Fix readme * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.