Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow disabling node autoprovisioning #2238

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: allow disabling node autoprovisioning #2238

merged 2 commits into from
Apr 26, 2024

Conversation

kumadee
Copy link
Contributor

@kumadee kumadee commented Apr 25, 2024 •
edited

  • This fix allows a GKE Standard cluster to be configured with no auto-provisioned node pool, but allow setting autocluster profile for user-provisioned node pools like created via gke-nodepool module.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@kumadee
fix: allow disabling node autoprovisioning
5bff314 
- This fix allows a GKE Standard cluster to be configured with no auto-provisioned node pool,
  but allow setting autocluster profile for user-provisioned node pools like created via `gke-nodepool` module.
@kumadee kumadee marked this pull request as ready for review April 25, 2024 14:15
@juliocc
Copy link
Collaborator

juliocc commented Apr 26, 2024

Can't this be achieved by setting cluster_autoscaling to null?

@kumadee
Copy link
Contributor Author

kumadee commented Apr 26, 2024

Can't this be achieved by setting cluster_autoscaling to null?

Yes, one can disable auto node provisioning by setting cluster_autoscaling to null, and that is what I currently do.
But the side effect is that I am unable to change the default value of cluster_autoscaling.autoscaling_profile to OPTIMIZE_UTILIZATION via terraform and have to change it externally.

@juliocc juliocc enabled auto-merge (squash) April 26, 2024 07:08
@juliocc juliocc merged commit 64ac89d into GoogleCloudPlatform:master Apr 26, 2024
9 checks passed
dibaskar-google pushed a commit to dibaskar-google/cloud-foundation-fabric that referenced this pull request May 14, 2024
@kumadee @juliocc @dibaskar-google
fix: allow disabling node autoprovisioning (GoogleCloudPlatform#2238)
1ede7cb 
- This fix allows a GKE Standard cluster to be configured with no auto-provisioned node pool,
  but allow setting autocluster profile for user-provisioned node pools like created via `gke-nodepool` module.

Co-authored-by: Julio Castillo <jccb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kumadee @juliocc