Add support for reserved_internal_range in net-vpc #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
approved these changes
May 14, 2024
|
are you intentionally removing private_nat subnet support? |
Yowz I missed that 🤣 |
juliocc
previously requested changes
May 14, 2024
ludoo
requested changes
May 14, 2024
tests caught it anyway :) |
|
Great catch Julio!
...which I did but this PR has a troubled backstory |
ludoo
reviewed
May 14, 2024
ludoo
approved these changes
May 14, 2024
sruffilli
added a commit
that referenced
this pull request
May 15, 2024
Adds support for reserved_internal_range to net-vpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider version 5.29.0 introduces reserved_internal_range, which triggered an unexpected error during plan (potentially due to secondary_ip_ranges being previously implemented with attr-as-blocks).
This PR adds explicit support for reserved_internal_range in net-vpc.