Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: fix audit logs when using pubsub as destination #675

Merged
merged 2 commits into from Jun 10, 2022

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jun 10, 2022

  • Fix FAST audit logging (stage0) when pubsub is used as destination
  • Split each organization-level logging sink of type logging to a separate logging bucket.
  • Add convenience output id to gcs module

@juliocc juliocc requested review from ludoo and sruffilli June 10, 2022 08:34
This commit also splits each organization-level logging sink of type
`logging` to a separate logging bucket.
@juliocc juliocc force-pushed the fast/fix-pubsub-audit-logs branch from 9e56dec to 29ce5f6 Compare June 10, 2022 10:25
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!!

modules/gcs/outputs.tf Show resolved Hide resolved
@juliocc juliocc removed the request for review from sruffilli June 10, 2022 11:52
@juliocc juliocc merged commit 6c63c6a into master Jun 10, 2022
@juliocc juliocc deleted the fast/fix-pubsub-audit-logs branch June 10, 2022 11:53
@ludoo ludoo changed the title Fix FAST audit logs when using pubsub as destination FAST: fix audit logs when using pubsub as destination Jun 10, 2022
@ludoo ludoo changed the title FAST: fix audit logs when using pubsub as destination FAST: Fix audit logs when using pubsub as destination Jun 10, 2022
@ludoo ludoo changed the title FAST: Fix audit logs when using pubsub as destination FAST: fix audit logs when using pubsub as destination Jul 31, 2022
@ludoo ludoo added the on:FAST label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants