Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connector create logic in cloud run module #729

Merged
merged 2 commits into from Jul 10, 2022
Merged

Fix connector create logic in cloud run module #729

merged 2 commits into from Jul 10, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jul 10, 2022 •
edited

Fixes #728 and lightly refactors for readability. A second readability pass would be nice to move the for_each logic used for containers to locals.

@ludoo ludoo requested a review from juliocc July 10, 2022 07:03
@ludoo ludoo merged commit 263cf96 into master Jul 10, 2022
@ludoo ludoo deleted the ludo/issue-728 branch July 10, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logic issue in Cloud Run module vpc_connector argument
1 participant
@ludoo