Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sample alert creation optional #850

Merged

Conversation

maunope
Copy link
Collaborator

@maunope maunope commented Sep 30, 2022

  • Made sample alert creation optional
  • Updated doc to explain alert can be created only after CF has run at least once

@maunope
Copy link
Collaborator Author

maunope commented Sep 30, 2022

linting failing with error code 3, not sure about that the catch is

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you fix linting errors (hint: read up on tfdoc in our contributing guide), this is good to go, thanks Mauri!

@maunope maunope merged commit 4f6cf40 into GoogleCloudPlatform:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants