Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support 2nd generation cloud function #872

Merged
merged 15 commits into from Oct 13, 2022

Conversation

som-nitjsr
Copy link
Contributor

adding support for 2nd generation cloud function and using http trigger as in case of enterprise there are lot of data and it takes lots of time . In my case function was getting timed out. so moved it to second generation where http trigger has 60 minutes of time out.
#817

This is Related to PR
#857

@juliocc
Copy link
Collaborator

juliocc commented Oct 12, 2022

Couple more comments:

  • The function resource for version 1 creates event_triggers, secret_environment_variables, and secret_volumes blocks. Can you ensure the version 2 resource considers those elements too?
  • In the dashboard you use an http trigger when you enable the version 2 function. Why don't you use the scheduler+pubsub topic already in place for the v1 function?

@som-nitjsr
Copy link
Contributor Author

Couple more comments:

  • The function resource for version 1 creates event_triggers, secret_environment_variables, and secret_volumes blocks. Can you ensure the version 2 resource considers those elements too?
  • In the dashboard you use an http trigger when you enable the version 2 function. Why don't you use the scheduler+pubsub topic already in place for the v1 function?

First one i will add.
for second i thought since people will mostly go for timeout issue and only http has timeout of 60 minutes other triggers still has the same timeout of 10 minute. and also we need to create the EventArc for pub sub trigger. if you still want i can fix that.

@juliocc
Copy link
Collaborator

juliocc commented Oct 13, 2022

First one i will add. for second i thought since people will mostly go for timeout issue and only http has timeout of 60 minutes other triggers still has the same timeout of 10 minute. and also we need to create the EventArc for pub sub trigger. if you still want i can fix that.

Cool. Let's start with the first one for now

som-nitjsr and others added 2 commits October 13, 2022 10:50
and secret_environment_variables for CF V2
@som-nitjsr
Copy link
Contributor Author

First one i will add. for second i thought since people will mostly go for timeout issue and only http has timeout of 60 minutes other triggers still has the same timeout of 10 minute. and also we need to create the EventArc for pub sub trigger. if you still want i can fix that.

Cool. Let's start with the first one for now

done

@juliocc juliocc merged commit a12da69 into GoogleCloudPlatform:master Oct 13, 2022
@juliocc
Copy link
Collaborator

juliocc commented Oct 13, 2022

@som-nitjsr thanks for the PR and following through with all the requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants