Refactor GKE nodepool for Terraform 1.3, refactor GKE blueprints and FAST stage #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
added
on:FAST
incompatible change
…orm/cloud-foundation-fabric into ludo/gke-nodepool-tf1.3
juliocc
approved these changes
Oct 12, 2022
ludoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the GKE nodepool module, so that it leverages
optionalin a similar way as the GKE cluster module.It also aligns blueprints and the FAST stage, and removes the extra variables used for cluster and nodepool defaults, as that can now be done in code via locals. One example of the new approach is in the examples of the multitenant fleet blueprint.