Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default nodepool creation fix #999

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Default nodepool creation fix #999

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7d1196
Default nodepool creation fix
Nov 22, 2022
5fbdc1d
Merge branch 'master' into default-nodepool-fix
ludoo Nov 22, 2022
c34cc4a
Removed comments and fixded formatting with fmt
Nov 22, 2022
e62cfd9
Merge branch 'default-nodepool-fix' of https://github.com/astianseb/c…
Nov 22, 2022
751586b
Merge branch 'master' into default-nodepool-fix
astianseb Nov 22, 2022
2956d3d
Refactored per PR comment
Nov 22, 2022
bbbec20
Merge branch 'master' into default-nodepool-fix
ludoo Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/gke-cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ resource "google_container_cluster" "cluster" {
enable_autopilot = var.enable_features.autopilot ? true : null

# the default nodepool is deleted here, use the gke-nodepool module instead
# node_config {}
node_config {
shielded_instance_config {
ludoo marked this conversation as resolved.
Show resolved Hide resolved
enable_secure_boot = var.enable_features.shielded_nodes ? true : null
enable_integrity_monitoring = var.enable_features.shielded_nodes ? true : null
}
}

addons_config {
dynamic "dns_cache_config" {
Expand Down