Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of CFT cli tool on golang #33

Merged
merged 5 commits into from
May 21, 2019
Merged

Initial implementation of CFT cli tool on golang #33

merged 5 commits into from
May 21, 2019

Conversation

kopachevsky
Copy link
Contributor

@kopachevsky kopachevsky commented May 16, 2019 •
edited
Loading

Ready for review

kopachevsky
kopachevsky commented May 16, 2019
View reviewed changes
cli/go.sum Outdated Show resolved Hide resolved
@morgante morgante changed the title Initial implementation of CFT cli tool on golang - not finished yet, created for early feedback [WIP] Initial implementation of CFT cli tool on golang May 17, 2019
morgante
morgante suggested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start/direction, thanks!

cli/Makefile Show resolved Hide resolved
cli/cft.go Outdated Show resolved Hide resolved
cli/cmd/root.go Outdated Show resolved Hide resolved
cli/go.sum Outdated Show resolved Hide resolved
@morgante morgante changed the title [WIP] Initial implementation of CFT cli tool on golang Initial implementation of CFT cli tool on golang May 17, 2019
@kopachevsky
Copy link
Contributor Author

Ready for review! @ocsig @morgante please take a look

@morgante morgante self-requested a review May 21, 2019 00:55
morgante
morgante suggested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good! Just one question and one small suggestion.

cli/cmd/root.go Show resolved Hide resolved
cli/Makefile Outdated Show resolved Hide resolved
@kopachevsky kopachevsky changed the title Initial implementation of CFT cli tool on golang Initial implementation of CFT cli tool on golang May 21, 2019
@morgante morgante merged commit 6b8b714 into GoogleCloudPlatform:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kopachevsky @morgante @googlebot