Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go.mod, move to go 1.14, update smaller base image #32

Merged
merged 2 commits into from Jul 12, 2020
Merged

Conversation

steren
Copy link
Collaborator

@steren steren commented Jul 11, 2020

Fix #30

@steren steren requested a review from ahmetb July 11, 2020 16:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2020
@steren
Copy link
Collaborator Author

steren commented Jul 11, 2020

oops sorry ignore for now, it doesn't run

@steren
Copy link
Collaborator Author

steren commented Jul 11, 2020

OK, good for review now, it runs.

@ahmetb
Copy link
Contributor

ahmetb commented Jul 11, 2020

If my memory serves me, we intentionally kept this to use ubuntu image base, so beginners can take a look at its source code and adapt the dockerfile for other languages in their apps.

@steren
Copy link
Collaborator Author

steren commented Jul 11, 2020

Mmm, on the opposite: this repo is not intended to serve as a boilerplate or hello world example.
Its single purpose is to offer the demo container. Which should contain as less as possible.

@ahmetb
Copy link
Contributor

ahmetb commented Jul 11, 2020

For the record, switching from alpine to Ubuntu-based image was your call: f8d7e31, 0ee75a7. I think we discussed this over a year ago as well and I was convinced Ubuntu is there so beginners can apt get new things into this sample Dockerfile with less friction. I'm indifferent otherwise. :)

@steren
Copy link
Collaborator Author

steren commented Jul 11, 2020

Thanks for the forensic.

My motivation was not to use Ubuntu, but to use a Google managed based image, under the assumption that it would be more secure and better maintained.

But container vulnerability scans says that Ubuntu contains a lot of known vulnerabilities. I prefer to optimize for reducing that number.

Sadly, I do not see any slim base image in gcr.io/cloud-marketplace/google, so I suggest to use alpine? Any other suggestion?

@steren steren merged commit 8c1f862 into master Jul 12, 2020
@steren steren deleted the dockerfile branch July 12, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Go 1.14, use go.mod use smaller base image
3 participants