Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: new jobs image publishing configuration #85

Merged
merged 2 commits into from Mar 15, 2024

Conversation

grayside
Copy link
Contributor

@grayside grayside commented Mar 15, 2024

Changes in this PR

  • Adds support for hello-job image tag
  • Renames build config "merge" (a triggering model) to "publish" (the purpose of the config)
  • Updates for easier-to-read script syntax
  • Switches to a pre-built pack container image

For comparison, see https://github.com/GoogleCloudPlatform/cloud-run-hello/blob/master/testing/jobs.merge.cloudbuild.yaml

Why a new file?

This change keeps the existing build config during a transition period, and comments the file to that purpose.

Why multiple changes in one PR

If someone wants I can break it up, but before arriving at this simple set of changes, I explored if this configuration should be made generic across the repository. Landing back on looks like several small changes but in fact is a re-simplification from a significant overhaul.

@grayside grayside requested a review from glasnt March 15, 2024 19:23
@grayside grayside self-assigned this Mar 15, 2024
@grayside grayside requested review from a team and removed request for glasnt March 15, 2024 19:26
Copy link

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the detailed description of what is intended by the changes proposed.

@grayside grayside merged commit 636084c into master Mar 15, 2024
4 checks passed
@grayside grayside deleted the pipeline-modernize-job-publish branch March 15, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants