Fixes for #20 #21 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,8 @@ | |||
| FROM google/debian:wheezy | |||
| ENV DEBIAN_FRONTEND noninteractive | |||
| RUN sed -i '1i deb http://gce_debian_mirror.storage.googleapis.com/ wheezy main' /etc/apt/sources.list | |||
| RUN apt-get update && apt-get install -y -qq --no-install-recommends wget unzip python php5-mysql php5-cli php5-cgi openjdk-7-jre-headless openssh-client && apt-get clean | |||
| RUN apt-get update && apt-get install -y -qq --no-install-recommends wget unzip python php5-mysql php5-cli php5-cgi openjdk-7-jre-headless openssh-client python-openssl && apt-get clean | |||
There was a problem hiding this comment.
can you change apt-get clean, with rm -rf /var/lib/apt/lists/*? I think google/debian already does apt-get clean after each install now.
There was a problem hiding this comment.
This was not a point of my change.
I think you can do this in separate changeset.
|
Sorry for the late followup, this looks good to me and thanks for reporting and fixing the issue, just 2 little nits. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #20 #21
CLA already signed
Build successed: https://registry.hub.docker.com/u/appunite/cloud-sdk/build_id/35948/code/bo4vtfvtpkdbxmyb3juz49/
Cheers :)