Support multi-arch images #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has changes that break internal tooling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #232
Intent of this PR
It has been reported that some components that come with gcloud do not work properly, but this problem is not related to Image, but to the compatibility between the user's machine and the component, so it should be addressed in the component repository. I don't think it needs to be addressed in this repository.
Also, at the moment, when using the M1 Mac, the container hangs because the linux/amd64 emulation does not work properly. Therefore, I'd be more than happy to support the use of just some of the components, compared to the current situation.
Since there is no M1 Mac support at this time, I feel that it would be fine to release mulch-arch support with documentation that support is not complete.
We hope that this PR will be a good opportunity for you to be proactive in supporting multi-arch.
If you have any problems, please feel free to close this PR.
I would be happy if you think this work will be useful in the future.
Note
The following links may be helpful.
I have confirmed that I can build and push the image without any problems.
Example:
docker buildx build --platform linux/arm64 -t takanakahiko/test --push .I'm using
'linux/amd64,linux/arm/v7,linux/arm64'as the supported architecture, but I'd like to hear from the maintainer if there is no problem.