Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests hang on malformed SQL syntax #282

Closed
elefeint opened this issue Oct 14, 2020 · 4 comments · Fixed by #290
Closed

Tests hang on malformed SQL syntax #282

elefeint opened this issue Oct 14, 2020 · 4 comments · Fixed by #290
Assignees
@elefeint
Labels
P3 type: bug Something isn't working
Milestone
0.3.0

Comments

@elefeint
Copy link
Contributor

Investigate whether test failure or actual driver failing to propagate issue.
@elefeint
Copy link
Contributor Author

The hanging only happens on DML queries executed in transaction. The issue is that we attach a listener to the transaction step, but the failure is not propagated through transaction steps.
There are two ways this could be addressed:

  1. Get client library to propagate failure in async function up to the chained transaction steps futures.
  2. Refactor driver code to work similarly to SELECT statements, in which the asynchronous operation is returned and can have callbacks attached. Currently, the last transaction step future is returned.

@elefeint
Copy link
Contributor Author

cc/ @dmitry-s

@elefeint
Copy link
Contributor Author

Filed googleapis/java-spanner#514 to track the client library side.

@elefeint elefeint added the type: bug Something isn't working label Oct 15, 2020
@elefeint
Copy link
Contributor Author

Te-test when google-cloud-spanner:2.0.3 is released.

@elefeint elefeint added awaiting awaiting another PR or issue P2 labels Oct 22, 2020
@elefeint elefeint added this to the 0.3.0 milestone Oct 22, 2020
@meltsufin meltsufin added P3 and removed P2 labels Nov 9, 2020
@elefeint elefeint self-assigned this Nov 13, 2020
@elefeint elefeint removed the awaiting awaiting another PR or issue label Nov 13, 2020
@elefeint elefeint mentioned this issue Nov 13, 2020
Merged
elefeint added a commit that referenced this issue Nov 16, 2020
@elefeint
upgrade google BOM to pull in unpropagated failure fix (#290)
7eee712 
Bring in the latest client library, with the fix for googleapis/java-spanner#514.

Fixes #282.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
P3 type: bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

upgrade google BOM to pull in unpropagated failure fix GoogleCloudPlatform/cloud-spanner-r2dbc
2 participants
@meltsufin @elefeint