Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move connection factory config to properties #405

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Move connection factory config to properties #405

merged 1 commit into from
Jul 9, 2021

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Jul 9, 2021

Also add integration test because we should have caught this at dependabot upgrade.

Fixes #404.
Fixes #218.

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elefeint elefeint requested review from dzou and meltsufin July 9, 2021 17:10
@elefeint elefeint merged commit cc4d4f9 into main Jul 9, 2021
@elefeint elefeint deleted the spring-data-options-capable-connection-factory branch July 9, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzou dzou dzou approved these changes

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Data R2DBC sample broke with upgrade to Spring Boot 2.5.1 Add integration test for Spring Data sample
3 participants
@elefeint @dzou @meltsufin