Skip to content

Commit

Permalink
fix: custom drivers report error on cleanup (#102)
Browse files Browse the repository at this point in the history
  • Loading branch information
enocom committed Feb 8, 2022
1 parent 901f0fa commit 648b75a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
5 changes: 1 addition & 4 deletions mysql/mysql/mysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,7 @@ func RegisterDriver(name string, opts ...cloudsqlconn.Option) (func() error, err
sql.Register(name, &mysqlDriver{
d: &mysql.MySQLDriver{},
})
return func() error {
d.Close()
return nil
}, nil
return func() error { return d.Close() }, nil
}

type mysqlDriver struct {
Expand Down
5 changes: 1 addition & 4 deletions postgres/pgxv4/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,7 @@ func RegisterDriver(name string, opts ...cloudsqlconn.Option) (func() error, err
sql.Register(name, &pgDriver{
d: d,
})
return func() error {
d.Close()
return nil
}, nil
return func() error { return d.Close() }, nil
}

type pgDriver struct {
Expand Down
5 changes: 1 addition & 4 deletions sqlserver/mssql/mssql.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ func RegisterDriver(name string, opts ...cloudsqlconn.Option) (func() error, err
sql.Register(name, &sqlserverDriver{
d: d,
})
return func() error {
d.Close()
return nil
}, nil
return func() error { return d.Close() }, nil
}

type csqlDialer struct {
Expand Down

0 comments on commit 648b75a

Please sign in to comment.