Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return a friendly error if the dialer is closed #766

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: return a friendly error if the dialer is closed #766

merged 1 commit into from
Apr 9, 2024

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 8, 2024

@enocom enocom requested a review from a team as a code owner April 8, 2024 21:22
@enocom enocom enabled auto-merge (squash) April 9, 2024 15:52
@enocom enocom merged commit d1c13e0 into main Apr 9, 2024
12 of 13 checks passed
@enocom enocom deleted the friendly-errors branch April 9, 2024 15:53
@release-please release-please bot mentioned this pull request Apr 9, 2024
Merged
@jackwotherspoon jackwotherspoon mentioned this pull request Apr 19, 2024
Closed
@rosecodym
Copy link

This is extremely minor, but did this change cause the doc comment on Close to longer be correct? (Specifically, I don't think that "additional dial operations may succeed" anymore.) I only noticed because that comment slowed me down a bit before realizing that we had the same situation as #777.

@enocom
Copy link
Member Author

enocom commented May 3, 2024

Yep, you're right. We missed that in this PR. Fixed here: #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enocom @rosecodym @jackwotherspoon