Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for TPC #1901

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat: add support for TPC #1901

merged 1 commit into from
Apr 15, 2024

Conversation

ttosta-google
Copy link
Collaborator

@ttosta-google ttosta-google commented Mar 15, 2024 •
edited

Add support for Trusted Partner Cloud (TPC) environments through cloudSqlUniverseDomain property.

Example:

Properties connProps = new Properties();
connProps.setProperty("cloudSqlUniverseDomain", "test-universe.test");

Fixes #1894

@ttosta-google ttosta-google force-pushed the gh-1894-tpc-support branch 2 times, most recently from 841e9cc to b814e2a Compare March 20, 2024 13:25
@ttosta-google ttosta-google marked this pull request as ready for review March 20, 2024 13:37
@ttosta-google ttosta-google requested a review from a team as a code owner March 20, 2024 13:37
jackwotherspoon
jackwotherspoon reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, will run a few tests and then take another look prior to approving

@jackwotherspoon
Copy link
Collaborator

Ran a whole bunch of manual tests:

  • TPC creds + TPC universe domain set -> ✅

Error paths:

  • TPC creds + no universe domain set -> 🟥
  • TPC creds + wrong universe domain set -> 🟥
  • GDU creds + TPC universe domain set -> 🟥
  • Both universe domain and API endpoint set -> 🟥

Good to go and can merge @ttosta-google 🚀 👍

@ttosta-google ttosta-google merged commit f6764dd into main Apr 15, 2024
17 checks passed
@ttosta-google ttosta-google deleted the gh-1894-tpc-support branch April 15, 2024 14:57
@release-please release-please bot mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@enocom enocom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for TPC
3 participants
@ttosta-google @jackwotherspoon @enocom