Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare used maven dependencies explicitly #478

Merged

Conversation

honnix
Copy link
Contributor

@honnix honnix commented May 3, 2021

Change Description

Declare used dependencies in pom.xml explicitly instead of relying on transitive dependencies.

Maybe it is better to dependencyManagement everything, but that feels like a separated PR.

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Relevant issues:

@google-cla google-cla bot added the cla: yes label May 3, 2021
@kurtisvg kurtisvg assigned shubha-rajan and unassigned enocom May 3, 2021
@kurtisvg kurtisvg requested a review from shubha-rajan May 3, 2021 14:19
@shubha-rajan shubha-rajan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@shubha-rajan shubha-rajan merged commit 8483003 into GoogleCloudPlatform:main May 3, 2021
@honnix honnix deleted the fix-transitive-dep-declaration branch May 3, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Used but undeclared maven dependencies results runtime error
4 participants