Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add universeDomain option to Connector #331

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Conversation

jackwotherspoon
Copy link
Collaborator

In googleapis-common v7.1.0 a GlobalOption for universeDomain was added with the respective error handling for TPC support.

This gives the Node Connector support TPC by adding the universeDomain as a ConnectorOptions:

import { Connector } from '@google-cloud/cloud-sql-connector';

const connector = new Connector({
    universeDomain: 'my-universe-domain'
});

Ref: googleapis/nodejs-googleapis-common#548

@jackwotherspoon jackwotherspoon self-assigned this Apr 24, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner April 24, 2024 14:13
package.json Outdated Show resolved Hide resolved
@jackwotherspoon jackwotherspoon changed the title WIP: add universeDomain option to Connector feat: add universeDomain option to Connector Apr 24, 2024
@jackwotherspoon jackwotherspoon merged commit 651634d into main Apr 24, 2024
22 checks passed
@jackwotherspoon jackwotherspoon deleted the tpc-support branch April 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants