docs: add typeorm examples #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
add-examples-typeorm
branch
from
a39e50f
to
d338874
Compare
jackwotherspoon
requested changes
Nov 22, 2023
ruyadorno
force-pushed
the
add-examples-typeorm
branch
from
d338874
to
266a1b0
Compare
sounds like a good idea, I'm just thinking what a good file name for each sample would be in that case 🤔 |
Adds TypeORM samples along with a new CI target to run tests against the provided samples, making sure they're always valid usage. Fixes: #112
ruyadorno
force-pushed
the
add-examples-typeorm
branch
from
266a1b0
to
0332b43
Compare
ruyadorno
commented
Nov 23, 2023
|
|
||
| - name: Link self-direct dependency | ||
| run: npm link @google-cloud/cloud-sql-connector | ||
|
|
There was a problem hiding this comment.
moved this block since it was interfering with the npm uninstall from the Setup v14.x-compatible tap step above
.github/workflows/tests.yml
Outdated
Comment on lines
317
to
321
| permissions: | ||
| contents: 'read' | ||
| id-token: 'write' | ||
| issues: write | ||
| pull-requests: write |
There was a problem hiding this comment.
are all of these permissions reqquired? issues and pull_request are for flakybot... we are not running flakybot here are we?
There was a problem hiding this comment.
worth maybe testing removing some...
There was a problem hiding this comment.
no need to run flakybot on these, I'll remove issues and pull_request then!
ruyadorno
force-pushed
the
add-examples-typeorm
branch
from
7f08d49
to
b8040db
Compare
ruyadorno
force-pushed
the
add-examples-typeorm
branch
from
b8040db
to
b61095b
Compare
jackwotherspoon
requested changes
Nov 24, 2023
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
ruyadorno
commented
Nov 24, 2023
jackwotherspoon
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TypeORM samples along with a new CI target to run tests against the provided samples, making sure they're always valid usage.
Fixes: #112