Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTTP GET to /quitquitquit admin api for k8s compatibility #1946

Closed
hessjcg opened this issue Sep 13, 2023 · 0 comments · Fixed by #1947 or #1932
Closed

Allow HTTP GET to /quitquitquit admin api for k8s compatibility #1946

hessjcg opened this issue Sep 13, 2023 · 0 comments · Fixed by #1947 or #1932
Assignees
@hessjcg
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Sep 13, 2023 •
edited
Loading

Feature Description

Kubernetes pod lifecycle handler allows the kubernetes api to make an HTTP GET request to a pod after the pod starts up or shuts down. This could be used to gracefully terminate the proxy when another container on the pod exits.

However, the proxy will only respond to HTTP POST requests to /quitquitquit. K8s lifecycle handler cannot make a POST request.

So in order to use the lifecycle handler, the proxy /quitquitquit endpoint should respond to both GET and POST request.
@hessjcg hessjcg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 13, 2023
@hessjcg hessjcg assigned hessjcg and unassigned jackwotherspoon Sep 13, 2023
@hessjcg hessjcg added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 13, 2023
@hessjcg hessjcg mentioned this issue Sep 13, 2023
Merged
hessjcg added a commit that referenced this issue Sep 14, 2023
@hessjcg
feat: /quitquitquit api now responds to HTTP GET and POST requests. (#…
e5ebb48 
…1947)

The /quitquitquit endpoint used to return a 400 error when it received a request other than an HTTP POST. Now, it
will shut down the proxy if it receives either a GET or a POST request. This will make it possible for kubernetes
pod lifecycle handlers to gracefully signal the proxy to shut down.

Fixes #1946
@release-please release-please bot mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@jackwotherspoon @hessjcg