Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for credentials file #1151

Merged
merged 5 commits into from
Apr 11, 2022
Merged

feat: add support for credentials file #1151

merged 5 commits into from
Apr 11, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Mar 29, 2022

No description provided.

@enocom enocom requested a review from kurtisvg March 29, 2022 20:22
kurtisvg
kurtisvg suggested changes Mar 31, 2022
View reviewed changes
.envrc.example Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
testsV2/postgres_test.go Outdated Show resolved Hide resolved
@enocom enocom force-pushed the v2 branch 2 times, most recently from d4f06c6 to cc1357e Compare April 6, 2022 15:58
@enocom
feat: add support for credentials file flag
7931f4f 
This commit also back fills some e2e tests for the token flag as well.
@enocom enocom requested a review from kurtisvg April 7, 2022 17:56
enocom
enocom commented Apr 7, 2022
View reviewed changes
testsV2/mysql_test.go Outdated Show resolved Hide resolved
kurtisvg
kurtisvg suggested changes Apr 8, 2022
View reviewed changes
.gitignore Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
testsV2/connection_test.go Outdated Show resolved Hide resolved
testsV2/mysql_test.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg April 8, 2022 16:03
kurtisvg
kurtisvg suggested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to push some changes :)

.gitignore Show resolved Hide resolved
kurtisvg
kurtisvg reviewed Apr 8, 2022
View reviewed changes
testsV2/postgres_test.go Outdated Show resolved Hide resolved
testsV2/postgres_test.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg April 11, 2022 15:38
@enocom enocom merged commit 33b9c95 into v2 Apr 11, 2022
@enocom enocom deleted the credential-file branch April 11, 2022 17:33
enocom added a commit that referenced this pull request Apr 11, 2022
@enocom
feat: add support for credentials file (#1151)
dd7198d
enocom added a commit that referenced this pull request May 5, 2022
@enocom
feat: add support for credentials file (#1151)
473434d
enocom added a commit that referenced this pull request May 5, 2022
@enocom
feat: add support for credentials file (#1151)
f1ae7ea
enocom added a commit that referenced this pull request Jun 17, 2022
@enocom
feat: add support for credentials file (#1151)
bbd490f
enocom added a commit that referenced this pull request Jul 12, 2022
@enocom
feat: add support for credentials file (#1151)
7261d31
enocom added a commit that referenced this pull request Jul 27, 2022
@enocom
feat: add support for credentials file (#1151)
8614cf5
enocom added a commit that referenced this pull request Aug 23, 2022
@enocom
feat: add support for credentials file (#1151)
b666693
enocom added a commit that referenced this pull request Aug 29, 2022
@enocom
feat: add support for credentials file (#1151)
63a1063
@release-please release-please bot mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enocom @kurtisvg