Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for min ready instances #1496

Merged
merged 16 commits into from
Nov 8, 2022
Merged

feat: add support for min ready instances #1496

merged 16 commits into from
Nov 8, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Oct 19, 2022

Fixes #1375.

@enocom enocom requested a review from a team October 19, 2022 19:56
@enocom enocom marked this pull request as draft October 19, 2022 20:38
@kurtisvg
Copy link
Contributor

Would this make more sense as a query parameter on the endpoint? Might be less invasive if the change is limited there as well

@enocom
Copy link
Member Author

enocom commented Oct 21, 2022

Great idea. I love it.

@enocom enocom marked this pull request as ready for review October 21, 2022 18:24
@enocom enocom mentioned this pull request Oct 21, 2022
Closed
hessjcg
hessjcg requested changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a unit test for when min-ready is not set. Optional: the ready() logic could be simplified and made clearer.

internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck_test.go Show resolved Hide resolved
kurtisvg
kurtisvg suggested changes Oct 24, 2022
View reviewed changes
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
kurtisvg
kurtisvg suggested changes Oct 25, 2022
View reviewed changes
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg October 26, 2022 15:30
hessjcg
hessjcg approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The logic is correct. I provided a comment on the logic in ready() I'm curious for my own learning what you think.

internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
internal/healthcheck/healthcheck_test.go Show resolved Hide resolved
@enocom enocom requested a review from hessjcg November 1, 2022 16:59
kurtisvg
kurtisvg approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

@enocom enocom merged commit 73e2999 into main Nov 8, 2022
@enocom enocom deleted the config-readiness branch November 8, 2022 00:01
@release-please release-please bot mentioned this pull request Nov 8, 2022
Merged
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Jan 15, 2023
@enocom
feat: add support for min ready instances
fd38f90 
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1496.
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Jan 18, 2023
@enocom
feat: add support for min ready instances
a5b74a8 
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1496.
@enocom enocom mentioned this pull request Jan 18, 2023
Merged
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Jan 18, 2023
@enocom
feat: add support for min ready instances (#229)
f9d262a 
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1496.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@hessjcg hessjcg Awaiting requested review from hessjcg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readiness check supports configuring minimum number of ready instances
3 participants
@enocom @kurtisvg @hessjcg