Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Ruby version, tutorial notes for multi-containers #1813

Merged
merged 3 commits into from
May 26, 2023

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented May 25, 2023

Changes:

  • Update Ruby version from 2.7.4 (EOL) to 3.2.2 (latest)
  • Add explicit rack server (probably due to major Ruby version update)

Doc updates:

  • Removed referenced to "2nd gen" Cloud SQL (not mentioned in docs or UI)
  • Added optional note to create a user, or use default "postgres"
  • Added API enabling (Cloud Build and Cloud Run prompted in CLI, Cloud SQL Admin isn't, so added all three)
  • Added optional note around using Secret Manager rather than hardcoding password as an environment variable, linking to docs
  • Added note around how the default service account will have permission to connect to Cloud SQL, but explicit permission required for custom service accounts
  • Fixed filename on gcloud run command

Other improvements that can be made (but require more work):

cc @shubha-rajan for review

Happy to also do the same changes to GoogleCloudPlatform/alloydb-auth-proxy once this is merged.

@glasnt glasnt requested a review from a team as a code owner May 25, 2023 04:11
@jackwotherspoon
Copy link
Collaborator

Thanks @glasnt! These look like great improvements!

@jackwotherspoon jackwotherspoon added the tests: run Label to trigger Github Action tests. label May 26, 2023
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label May 26, 2023
@jackwotherspoon jackwotherspoon changed the title feat: update Ruby version, tutorial notes for multi-containers docs: update Ruby version, tutorial notes for multi-containers May 26, 2023
@jackwotherspoon jackwotherspoon merged commit 804ca53 into GoogleCloudPlatform:main May 26, 2023
15 checks passed
@jackwotherspoon
Copy link
Collaborator

Thanks for this @glasnt ! If you would be so kind to port these same changes over to the alloydb-auth-proxy too that would be greatly appreciated 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants