Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label container images correctly #2061

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: label container images correctly #2061

merged 1 commit into from
Dec 8, 2023

Conversation

enocom
Copy link
Member

@enocom enocom commented Dec 8, 2023

Fixes #2060

@enocom enocom requested a review from a team as a code owner December 8, 2023 17:25
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, nice catch!

@enocom
Copy link
Member Author

enocom commented Dec 8, 2023

Running, docker inspect <image>:

Before:

"Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "65532",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt"
            ],
            "Cmd": null,
            "Image": "",
            "Volumes": null,
            "WorkingDir": "/home/nonroot",
            "Entrypoint": [
                "/cloud-sql-proxy"
            ],
            "OnBuild": null,
            "Labels": null
        },

After:

"ContainerConfig": {
            "Hostname": "7b4a7a6a0748",
            "Domainname": "",
            "User": "65532",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt"
            ],
            "Cmd": [
                "/bin/sh",
                "-c",
                "#(nop) ",
                "ENTRYPOINT [\"/cloud-sql-proxy\"]"
            ],
            "Image": "sha256:32ef7b65ede49d79f7827090bffb44625274298fb0f919f46272569f4d062ef1",
            "Volumes": null,
            "WorkingDir": "/home/nonroot",
            "Entrypoint": [
                "/cloud-sql-proxy"
            ],
            "OnBuild": null,
            "Labels": {
                "org.opencontainers.image.source": "https://github.com/GoogleCloudPlatform/cloud-sql-proxy"
            }
        },

@enocom enocom merged commit f071d38 into main Dec 8, 2023
12 checks passed
@enocom enocom deleted the label-fix branch December 8, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image labels are misplaced
2 participants