Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question/daisy] Why no region parameter? #445

Closed
gut opened this issue Jun 14, 2018 · 4 comments
Closed

[question/daisy] Why no region parameter? #445

gut opened this issue Jun 14, 2018 · 4 comments

Comments

@gut
Copy link
Contributor

gut commented Jun 14, 2018

I'm implementing ForwardingRule step on daisy as requested on #437 (comment) but I see that daisy is not ready for using region as a parameter. In order to implement it I thought about:

  1. Implicitly define it from zone when needed (basically region = zone[:-2])
  2. Add a parameter -region to be passed by command line for supplying that information, otherwise a valid error like no region provided in step or workflow might occur.

What's your opinion on this?

@gut
Copy link
Contributor Author

gut commented Jun 14, 2018

@zmarano @adjackura

@adjackura
Copy link
Contributor

adjackura commented Jun 14, 2018 via email

@gut
Copy link
Contributor Author

gut commented Jun 15, 2018

Working only with regional resources? I always instantiate a machine so I always needed to define a zone.

I can implement this later, but for now, please check the first approach I implemented on #434 , specifically c9f1884#diff-7b1669af81e6327ae6d38b7c32b4003bR57

@gut
Copy link
Contributor Author

gut commented Jun 27, 2018

well, It's working thanks to #434. I'll soon make use of it again for managing subnetworks on daisy so I guess this task can be closed for now

@gut gut closed this as completed Jun 27, 2018
gaohannk pushed a commit to gaohannk/compute-image-tools that referenced this issue May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants