Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onestep image from AWS #1261

Merged
merged 28 commits into from Jul 14, 2020
Merged

onestep image from AWS #1261

merged 28 commits into from Jul 14, 2020

Conversation

fiona-liu
Copy link
Contributor

@fiona-liu fiona-liu commented Jun 17, 2020

This PR adds implements the core functionality of image import from AWS.

  1. Authentication process from AWS
  2. Export AMI to an image file in S3
  3. Transfer image file from S3 to GCS
  4. Import image into GCE

The implementation is under the layer of import from cloud provider to have the flexibility for import from Azure in the future.

@google-oss-robot
Copy link
Collaborator

Hi @fiona-liu. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cli_tools/common/utils/logging/service/log_entry.go Outdated Show resolved Hide resolved
cli_tools/gce_onestep_image_import/README.md Outdated Show resolved Hide resolved
cli_tools/gce_onestep_image_import/main.go Outdated Show resolved Hide resolved
cli_tools/gce_onestep_image_import/main.go Outdated Show resolved Hide resolved
@dntczdx dntczdx requested review from dntczdx and adjackura and removed request for EricEdens and zoran15 July 1, 2020 18:40
@fiona-liu fiona-liu marked this pull request as ready for review July 1, 2020 18:47
@dntczdx dntczdx changed the title [not ready for review] onestep image from AWS onestep image from AWS Jul 6, 2020
Copy link
Contributor

@dntczdx dntczdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please also get Andrew's approval

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adjackura, dntczdx, fiona-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@dntczdx dntczdx merged commit f179960 into GoogleCloudPlatform:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants