daisy/: added variable parsing to resize-disk. #1280
Conversation
|
Hi @hegao12. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
daisy/step_resize_disks.go
Outdated
| @@ -30,13 +31,23 @@ type ResizeDisk struct { | |||
| compute.DisksResizeRequest | |||
| // Name of the disk to be resized | |||
| Name string | |||
| // SizeGb in string format to parse variables in workflow | |||
| SizeGbVar string "json:\"sizeGb,omitempty\"" | |||
There was a problem hiding this comment.
You can call it SizeGb (the same as the int field in DiskResizeRequest). In populate, you can refer to the int field as DiskResizeRequest.SizeGb.
There was a problem hiding this comment.
If so, all the others places that uses SizeGb will need to be changed to DiskResizeRequest.SizeGb. I'm not sure about all the places where it is used.
There was a problem hiding this comment.
In our code base it's only step_resize_disks and associated tests. They already reference it as DiskResizeRequest.SizeGb.
For other uses, since Daisy now uses Go modules, it will still be possible to reference the old version of the code by third parties.
There was a problem hiding this comment.
It's renamed now. Commit is amended.
BTW, if this is merged, when should I expect a new release of Daisy?
There was a problem hiding this comment.
This will be in the :latest build of Daisy within 10 minutes. Releases are manual so the earliest we can do it is tomorrow afternoon, once all the tests run.
Currently, the resize-disk commmand can only take integer input and cannot parse variables in a workflow. In order to allow variables in this command, a new field "SizeGbVar string" is added, and then its value is converted into int64 and stored in the original "SizeGb int64" field. In this way, everything else except the ResizeDisk struct fields and populate function remains untouched.
hegao12
force-pushed
the
resize-disk-with-variable
branch
from
66c01cc
to
a8504f2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hegao12, zoran15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, the resize-disk commmand can only take integer input and
cannot parse variables in a workflow. In order to allow variables in
this command, a new field "SizeGbVar string" is added, and then its
value is converted into int64 and stored in the original "SizeGb int64"
field. In this way, everything else except the ResizeDisk struct fields and
populate function remains untouched.