Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi-regional mapping in import/export wrappers #1350

Merged

Conversation

zoran15
Copy link
Contributor

@zoran15 zoran15 commented Sep 10, 2020

Update multi-regional mapping in import/export wrappers when determining the best zone to run import in when multi-regional storage is used: add new regions and sort based on VM cost.

…ing the best zone to run import in when multi-regional storage is used: add new regions and sort based on VM cost.
@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EricEdens
Copy link
Contributor

I'm curious, what's the impact if this goes stale? (Either in terms of missing regions, or having stale cost data?)

@zoran15
Copy link
Contributor Author

zoran15 commented Sep 10, 2020

I'm curious, what's the impact if this goes stale? (Either in terms of missing regions, or having stale cost data?)

  • Missing regions: if all other regions are down and a missing region is up, import will fail as it didn't attempt to run in it. Highly unlikely all other regions will be down so not a concern, but it's good to have an up-to-date list of regions just in case.
  • Stale cost data: import costs to the user will be more than the lowest price possible (if the cheapest region was selecged).

@zoran15 zoran15 merged commit 1126502 into GoogleCloudPlatform:master Sep 10, 2020
@zoran15 zoran15 deleted the update-multi-region-mapping branch September 15, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants