Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUSE import: Support 15.2; Parity for SLES for SAP #1356

Merged
merged 5 commits into from
Sep 21, 2020
Merged

SUSE import: Support 15.2; Parity for SLES for SAP #1356

merged 5 commits into from
Sep 21, 2020

Conversation

EricEdens
Copy link
Contributor

After this PR, the following versions of SLES will be importable:

  SLES SLES for SAP OpenSUSE
12.4 Existing Existing *
12.5 Existing New *
15.1 Existing New Existing
15.2 New New New

*: Not importable; Version is EOL.

This PR is split one of two from #1352, which I'm splitting to simplify the review process.

Testing:

  • Added e2e tests:
    • Each major version has one registered image that is imported as BYOL (4 total), this PR.
    • Each minor version has an unregistered image that is imported and verified (8 total), in the on-demand PR split from SLES import: Support conversion to on-demand #1352
  • Ran existing SLES and OpenSUSE tests from ci-daisy-e2e
  • Added Python unit test support in the utils package in linux_common. Currently they run manually; once this is pushed I'll add a prow config similar to the boot inspect pytest

@EricEdens EricEdens requested review from dntczdx and zoran15 and removed request for zmarano and adjackura September 16, 2020 16:49
@EricEdens EricEdens force-pushed the new-sles-versions branch 2 times, most recently from 5914b1a to d833250 Compare September 16, 2020 23:09
@EricEdens EricEdens force-pushed the new-sles-versions branch 2 times, most recently from aa2defd to ef665cc Compare September 17, 2020 20:14
dntczdx
dntczdx reviewed Sep 17, 2020
View reviewed changes
daisy_workflows/linux_common/utils/configs.py
import shlex


def update_grub_conf(original: str, **configs: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To which OSs this func can apply? Can it fix the hybrid issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the linux translators update the grub config; this new function is only used for SLES at the moment.

Can it fix the hybrid issue?

Talked offline -- this PR doesn't address any of the findings in b/168671324 with respect to SLES 12.5's hybrid booting.

dntczdx
dntczdx approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@dntczdx dntczdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntczdx, EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricEdens,dntczdx,zoran15]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@EricEdens EricEdens merged commit abf6758 into GoogleCloudPlatform:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoran15 zoran15 zoran15 approved these changes

@dntczdx dntczdx dntczdx approved these changes

Assignees

@zoran15 zoran15

@dntczdx dntczdx

Labels
approved size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricEdens @google-oss-robot @zoran15 @dntczdx