SLES import: Support conversion to on-demand

[EricEdens]

This PR adds:

• Support for importing on-demand SLES and SLES for SAP guests. The imported guest is not required to have an active SLES subscription.

OS targets

Eight targets are available for the --os flag, covering all combinations of:

• Major version: 12, 15
• Flavor: SLES, SLES for SAP
• Subscription: BYOL, convert to on-demand

See cli_tools/common/utils/daisy/daisy_utils.go for the new targets.

Noteworthy changes

• The on-demand conversion runs in a chroot. This is required since SLES's registration code
  fingerprints the instance. Running in a guestfs appliance fails registration.
• Similarly, to support this fingerprinting, the Debian 9 import worker includes
  the license that will be applied to the final image.

Testing:

1. Added e2e tests:

• Each minor version has an unregistered image that is imported and verified (8 total)
• Each major version has one registered image that is imported as BYOL (4 total)

2. Ran SLES and OpenSUSE tests from ci-daisy-e2e

[google-oss-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[EricEdens]

/test all

[dntczdx]

There are many "no changes" file included, is it by accident?

[EricEdens]

There are many "no changes" file included, is it by accident?

Good question -- the message means that it's an empty file. These occur for two reasons:

1. init.py: These are for Python's package search: https://docs.python.org/3/tutorial/modules.html
2. Some files in the test-data directory are empty. They're used when testing check_root, which in some cases is only looking for a file to be present.

compute-image-tools/daisy_workflows/image_import/suse/suse_import/on_demand/validate_chroot.py

Line 67 in 2390aef

def check_root(fs_root: Path, runtime_dir: Path,

[dntczdx]

Overall lgtm, e2e test is the real gate for the correctness

[zoran15]

To whom is this instruction addressed? Us?

Do we have a notification system in place for new versions of tarballs?

[EricEdens]

Future maintainers is the intended audience. The updated README gives clearer instructions.

Regarding the notification system, my current thinking is that our e2e tests have sufficient coverage to detect problems with on-demand conversion. All minor versions, and all flavors are covered.

[zoran15]

I think we chatted about it: maybe add instructions if those tests fail so we know what to do?

[zoran15]

Github is showing a missing new line in this file. Not sure it's an issue.

[EricEdens]

Updated with a trailing newline (I copied the file directly from a debian 9 worker instance).

[EricEdens]

@zoran15 -- Added a debugging tip when the on-demand import tests fail (talked about this offline)

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntczdx, EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [EricEdens,dntczdx,zoran15]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-robot]

New changes are detected. LGTM label has been removed.