Windows inspection: Use marketing versions #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoran15
reviewed
Oct 13, 2020
daisy_workflows/image_import/inspection/src/boot_inspect/model.py
Outdated
Show resolved
Hide resolved
EricEdens
force-pushed
the
windows-detection
branch
from
038b500
to
041f921
Compare
EricEdens
force-pushed
the
windows-detection
branch
from
041f921
to
19248c8
Compare
zoran15
approved these changes
Oct 14, 2020
dntczdx
approved these changes
Oct 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dntczdx, EricEdens, zoran15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gaohannk
pushed a commit
to gaohannk/compute-image-tools
that referenced
this pull request
Nov 5, 2020
Prior to this, boot-inspect returned NT versions for Windows' major and minor versions. There are a couple of problems with this: 1. Desktop and server use the same NT versions (server 2012r2 and desktop 8.1 have the same NT version) 2. NT versions are sometimes reused. Server 2016 and Server 2019 use the same NT version NT versions 6.0 and newer are included. Version mappings from https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, boot-inspect returned NT versions for Windows' major and minor versions. There are a couple of problems with this:
NT versions 6.0 and newer are included. Version mappings from https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions