Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL import: Surface yum_install errors #1394

Merged
merged 1 commit into from Oct 26, 2020

Conversation

EricEdens
Copy link
Contributor

@EricEdens EricEdens commented Oct 14, 2020

Audited ten recent failures, and none were related to the incorrect OS being specified. This makes sense, since the newer change [1] would have overwritten this error message with correct OS if it were indeed mispecified. After this change, the actual error will be more prominent to the user (rather than logged as the second-to-last line).

Failures from audit:

  1. Repositories unreachable (local file, uncreachable URL)
  2. Corrupt rpm database
  3. Package conflicts

__

  1. https://github.com/GoogleCloudPlatform/compute-image-tools/blob/f5a91c65376c26d14c93854a42d408fc2da41a81/cli_tools/gce_vm_image_import/importer/errors.go#L28-L27

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntczdx, EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricEdens,dntczdx,zoran15]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EricEdens EricEdens merged commit d19483e into GoogleCloudPlatform:master Oct 26, 2020
gaohannk pushed a commit to gaohannk/compute-image-tools that referenced this pull request Nov 5, 2020
Audited ten recent failures, and none were related to the incorrect OS being specified. This makes sense, since the newer change [1] would have overwritten this error message with correct OS if it were indeed mispecified. After this change, the actual error will be more prominent to the user (rather than logged as the second-to-last line).

Failures from audit:

1. Repositories unreachable (local file, uncreachable URL)
2. Corrupt rpm database
3. Package conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants