GMI import worker: Use alphabetic prefix on data disks #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
EricEdens
force-pushed
the
gmi-disk-names
branch
from
ade9a14
to
b37d4d5
Compare
|
/test all |
zoran15
approved these changes
Feb 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EricEdens, zoran15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was caused by #1512, and was observed in the e2e tests:
cannot create instance: bad InitializeParams.DiskName: "-1"; * cannot create disk "-1"; resource lookup error: unknown resource type: "projects/compute-image-test-pool-001/zones/us-central1-c/disks/-1"https://prow.k8s.io/view/gcs/compute-image-tools-test/logs/ci-ovf-import-e2e-tests-daily/1357763952053850112
It occurred since the instance name was being used as a prefix for data disk names; in GMI import, the use doesn't specify an instance name.