Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rollout] new rollout config #1751

Merged
merged 26 commits into from Dec 2, 2021
Merged

Conversation

dntczdx
Copy link
Contributor

@dntczdx dntczdx commented Sep 14, 2021

This is a PR that added new cloudbuild config for new rollout mechanism.
cli_tools_cloudbuild_build.yaml is copied from cli_tools_cloudbuild.yaml but removed those pushing commands to "artifacts registry".
cli_tools_cloudbuild_deploy.yaml responses for pushing to "artifacts registry".
cli_tools_cloudbuild_release_workflow.yaml is new, which simply launches the new rollout workflow.

@dntczdx dntczdx removed the request for review from gaohannk September 14, 2021 19:30
Copy link
Contributor

@zoran15 zoran15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have these files in their own subfolder to avoid confusion with the old build YAML file? Also, to have them in one place since it's not one file anymore.

@dntczdx
Copy link
Contributor Author

dntczdx commented Sep 16, 2021

Can we have these files in their own subfolder to avoid confusion with the old build YAML file? Also, to have them in one place since it's not one file anymore.

sounds good, moved to "rollout"

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntczdx, EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricEdens,dntczdx,zoran15]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 16, 2021
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntczdx, EricEdens, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricEdens,dntczdx,zoran15]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dntczdx dntczdx merged commit 5a7eb2e into GoogleCloudPlatform:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants