Exception message not printed out if it's not json in runTransform #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mservidio
commented
Nov 5, 2019
ingestion/function/index.js
Outdated
| await dataset.createTable(config.destinationTable, { schema: config.metadata.fields }); | ||
| } | ||
| const transform = `SELECT ${transformQuery}, '${batchId}' AS ${processPrefix}_batch_id FROM \`${config.dataset}.${config.stagingTable}\``; | ||
| // const exists = tableExists(config.dataset, config.destinationTable); |
There was a problem hiding this comment.
For now, commenting out the exists check as it was broken. As such there is no change in behavior here. Once we address the mode/description issue we can add this back as needed.
mservidio
commented
Nov 5, 2019
| @@ -213,8 +214,10 @@ async function fromStorage(bucket, file) { | |||
| async function tableExists(datasetId, tableName) { | |||
There was a problem hiding this comment.
Fixed issue where this function wasn't returning a boolean.
|
LGTM |
salsferrazza
deleted the
#52-Exception-message-not-printed-out-if-it's-not-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: